Site Editor: Set IFRAME_REQUEST constant for classic theme site preview
#69535
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
Mamaduka
reviewed
Mar 12, 2025
| */ | ||
| function wp_initialize_site_preview_hooks() { | ||
| if ( ! defined( 'IFRAME_REQUEST' ) && isset( $_GET['wp_site_preview'] ) && 1 === (int) $_GET['wp_site_preview'] ) { | ||
| define( 'IFRAME_REQUEST', true ); |
There was a problem hiding this comment.
Great catch, @t-hamano! Today, I also learned about IFRAME_REQUEST 😄
t-hamano
force-pushed
the
classic-site-preview-iframe-request
branch
from
78242a5 to
bf6b891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚒️ WIP ⚒️
What?
Follow-up #69514
Related core PR: WordPress/wordpress-develop#8475
Note
Don't add
Backport to WP 6.8 Beta/RClabel to this PR. This is because the auto cherry-pick has failed in #69514. I plan to submit another PR to thewp/6.8branch that includes this PR and #69514.Why?
In #69514, We added a get parameter to hide admin bar in the classic theme site preview. However, we found that some plugins load code into the preview.
How?
To solve this problem, it seems best to define
IFRAME_REQUESTinstead of filteringshow_admin_barhook.Testing Instructions