Add helper function to construct XPath from indexed breadcrumbs #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add/embed-optimizer-min-height-reservation * 'trunk' of https://github.com/WordPress/performance: Move requiring of helper trait to bootstrap Reuse populate_url_metrics helper method Move duplicated logic into OD test helpers trait Output buffer as snapshot as message when assertEquals fails Move Optimization Detective test cases into separate files Move Embed Optimizer tests cases into separate files Move test cases into separate files
…ientRect This is a more reasonable as a default element size for something which would be LCP.
westonruter
added
[Type] Enhancement
5 tasks
westonruter
force-pushed
the
add/embed-optimizer-min-height-reservation
branch
3 times, most recently
from
1f5e5f8
to
77bea30
Compare
westonruter
force-pushed
the
add/embed-optimizer-min-height-reservation
branch
2 times, most recently
from
019526c
to
36e5620
Compare
westonruter
force-pushed
the
add/embed-optimizer-min-height-reservation
branch
from
f8971e9
to
a4bab7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1373 (comment)
It would be ideal if the "indexed breadcrumbs" could be passed around in the codebase and turned into XPath strings without having to hard-code the XPath string literals.
However, passing around
array( array( 'DIV', 0 ) )isn't necessarily feel so much better than/*[1][self::DIV].Something to let bake for awhile.