-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritize loading poster image of video LCP elements #1498
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
TODO: Add test cases. |
Yeah, sounds good. |
@@ -36,4 +36,7 @@ function image_prioritizer_register_tag_visitors( OD_Tag_Visitor_Registry $regis | |||
|
|||
$bg_image_visitor = new Image_Prioritizer_Background_Image_Styled_Tag_Visitor(); | |||
$registry->register( 'bg-image-tags', $bg_image_visitor ); | |||
|
|||
$video_visitor = new Image_Prioritizer_Video_Tag_Visitor(); | |||
$registry->register( 'video-tags', $video_visitor ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this something like image-prioritizer-video-poster-preloading
. The names I had chosen previously are too generic.
Summary
Fixes #1183
Relevant technical choices