Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wp-compat PHPStan extension #1545

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add wp-compat PHPStan extension #1545

wants to merge 1 commit into from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Sep 18, 2024 •
edited
Loading

Summary

Fixes #1535

@swissspidy is my favorite troublemaker 🙃 so I do what he says.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: szepeviktor <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

johnbillion/wp-compat 0.2.1 requires php >= 7.4 -> your php version (7.2; overridden via config.platform, actual: 8.3.11) does not satisfy that requirement.

This is why we can't have nice things 😞

@westonruter
Copy link
Member

The minimum PHP version was bumped to 7.2 in 6.6. It seems there is some momentum to get on newer versions. So perhaps 7.4 will follow soon?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 18, 2024 •
edited
Loading

I usually say that the WordPress ecosystem (core+3rd-party themes/plugins) is PHP 7.4 compatible.
https://wordpress.org/about/stats/#php_versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wp-compat PHPStan extension
3 participants
@szepeviktor @swissspidy @westonruter