Try using WP_HTML_Processor in Optimization Detective #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Enhancement
westonruter
commented
Sep 19, 2024
| * @since n.e.x.t | ||
| * @access private | ||
| */ | ||
| final class OD_HTML_Processor extends WP_HTML_Processor { |
There was a problem hiding this comment.
Uh, where is this file even being loaded?
westonruter
commented
Sep 19, 2024
| @@ -177,7 +177,14 @@ function od_optimize_template_output_buffer( string $buffer ): string { | |||
| } | |||
|
|
|||
| // If the initial tag is not an open HTML tag, then abort since the buffer is not a complete HTML document. | |||
| $processor = new OD_HTML_Tag_Processor( $buffer ); | |||
| if ( version_compare( get_bloginfo( 'version' ), strtok( '6.7', '-' ), '>=' ) ) { | |||
There was a problem hiding this comment.
Suggested change
| if ( version_compare( get_bloginfo( 'version' ), strtok( '6.7', '-' ), '>=' ) ) { | |
| if ( version_compare( strtok( get_bloginfo( 'version' ), ','), '6.7' ), '>=' ) ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a sub-PR of #1373. Make sure that PR is merged into
trunkbefore this one.