Skip to content

Commit

Permalink
Administration: Fix undefined element JS error in pagination handler.
Browse files Browse the repository at this point in the history
Follow up to [59727]. Handle cases where the `#current-page-selector` is not present on the page to prevent a JS warning.

Props tobiasbg, mamaduka, jorbin, joedolson. 
See #62534.

git-svn-id: https://develop.svn.wordpress.org/trunk@59746 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
joedolson committed Jan 30, 2025
1 parent 0dea78f commit 7c6678f
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions src/js/_enqueues/admin/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -1310,16 +1310,12 @@ $( function() {
$document.trigger( 'wp-notice-added' );
};

// Stores initial pagination value for comparison.
var initialPagedValue = document.querySelector( '#current-page-selector' ).value;

$( '.bulkactions' ).parents( 'form' ).on( 'submit', function( event ) {
var form = this,
submitterName = event.originalEvent && event.originalEvent.submitter ? event.originalEvent.submitter.name : false;

var currentPagedValue = form.querySelector( '#current-page-selector' ).value;
submitterName = event.originalEvent && event.originalEvent.submitter ? event.originalEvent.submitter.name : false,
currentPageSelector = form.querySelector( '#current-page-selector' );

if ( initialPagedValue !== currentPagedValue ) {
if ( currentPageSelector && currentPageSelector.defaultValue !== currentPageSelector.value ) {
return; // Pagination form submission.
}

Expand Down

0 comments on commit 7c6678f

Please sign in to comment.