-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Improve HTML semantics for table used in site-health debug tab #8209
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The th
header cells still need the mobile adjustments:
.health-check-table th,
.health-check-table td {
box-sizing: border-box;
display: block;
width: 100%;
word-wrap: break-word;
}
.health-check-table th,
.health-check-table td:first-child {
width: 100%;
padding-bottom: 0;
font-weight: 600;
}
@@ -166,6 +166,10 @@ are styled in the Privacy section of edit.css */ | |||
margin: 0 auto; | |||
} | |||
|
|||
.widefat.health-check-table th { | |||
font-size: 13px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also consider inherit
in case the admin font size increases, but the td
cells for these tables are 13px
anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sabernhardt, For now I have not changed it to inherit as per the comment, let me know if we need to do that as well, I would update the PR.
Trac ticket: https://core.trac.wordpress.org/ticket/62880
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.