Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch refresh for 38197 #8214

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

audrasjb
Copy link
Contributor

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@@ -3079,9 +3079,11 @@ function generic_ping( $post_id = 0 ) {
*
* @since 0.71
* @since 4.7.0 `$post` can be a WP_Post object.
* @since 6.8 Returns an array of pingback statuses indexed by link.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 6.8 Returns an array of pingback statuses indexed by link.
* @since 6.8.0 Returns an array of pingback statuses indexed by link.

@@ -3093,7 +3095,7 @@ function pingback( $content, $post ) {
$post = get_post( $post );

if ( ! $post ) {
return;
return [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return [];
return array();

Comment on lines +7 to +11
*
* @covers ::pingback
*/
class Tests_Comment_Pingback extends WP_UnitTestCase
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*
* @covers ::pingback
*/
class Tests_Comment_Pingback extends WP_UnitTestCase
{
*
* @covers ::pingback
*/
class Tests_Comment_Pingback extends WP_UnitTestCase {

Comment on lines +14 to +18
protected $response = [];
public function set_up() {
parent::set_up();

add_filter('pre_http_request', [$this, 'request_response']);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected $response = [];
public function set_up() {
parent::set_up();
add_filter('pre_http_request', [$this, 'request_response']);
protected $response = array();
public function set_up() {
parent::set_up();
add_filter( 'pre_http_request', array( $this, 'request_response' ) );

Comment on lines +21 to +23
public function tear_down()
{
remove_filter('pre_http_request', [$this, 'request_response']);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function tear_down()
{
remove_filter('pre_http_request', [$this, 'request_response']);
public function tear_down() {
remove_filter( 'pre_http_request', array( $this, 'request_response' ) );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants