Update packages for 6.8 Beta 1 #8224
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Thanks @Mamaduka! Doing some initial testing to ensure nothing obvious is broken, but no initial big red flags from me.
I see that this sync is including several new __experimental… settings, like __experimentalBorder and continues the use of existing __experimentalDefaultControls settings.
I've not been involved in these syncs in the past, but was under the impression that we were attempting to move away from shipping these kinds of features under the __experimental… prefix. Am I mistaken? Regardless, I don't think that's a blocker for this sync, since those settings could be stabilized to remove the prefix, or removed entirely prior to shipping a final release. I mainly want to make sure I understand your expectations for how this is meant to work.
| '@wordpress/dataviews/wp', | ||
| '@wordpress/icons', | ||
| '@wordpress/interface', | ||
| '@wordpress/interactivity', | ||
| '@wordpress/sync', | ||
| '@wordpress/undo-manager', | ||
| '@wordpress/upload-media', | ||
| '@wordpress/fields', |
There was a problem hiding this comment.
Noting the new packages being bundled and their purpose in the commit message would probably be a good idea.
There was a problem hiding this comment.
Noted! Only @wordpress/upload-media is the new package here; it looks like we missed synchronization of this config in past releases.
I'll double-check new values here before this is committed.
| @@ -56,6 +56,7 @@ | |||
| remove_action( 'init', 'register_block_core_query_pagination_numbers' ); | |||
| remove_action( 'init', 'register_block_core_query_pagination_previous' ); | |||
| remove_action( 'init', 'register_block_core_query_title' ); | |||
| remove_action( 'init', 'register_block_core_query_total' ); | |||
There was a problem hiding this comment.
👍🏻 New action being added to register the new core/query-total block.
@joemcgill, that only applies to JS API. The |
|
Thanks for clarifying! Do we have any documentation or best practice for why and when to use those prefixes for block.json features? If they are intended to be backward compatible, should we be looking to remove these prefixes? |
|
These aren't new configuration values; they just got enabled for those blocks. When those features are stable, we usually create iteration issues like #64314 and stabilize the keys. I don't recall any official docs, but it is probably worth documenting. |
There was a problem hiding this comment.
I was able to reproduce the error with the @wordpress/fields package, noted in the PR description.
I'm also seeing the following, which makes the site editor unusable currently.
Uncaught TypeError: Cannot read properties of undefined (reading 'initializeEditor')
at HTMLDocument.<anonymous> (site-editor.php:2369:16)
I'm adding request changes until we're confident in these being resolved in a way that doesn't totally block the site editor from being usable in trunk
To reproduce:
- Check out this PR
- Run
npm i && npm run build:dev - Visit the site editor with no other plugins activated
A list of known issues:
Trac ticket: https://core.trac.wordpress.org/ticket/62887
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.