Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove recovery_mode_clean_expired_keys cron event on Populate Network. #8225

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Debarghya-Banerjee
Copy link

@Debarghya-Banerjee Debarghya-Banerjee commented Jan 30, 2025

Trac Ticket: Core-61450

Description

  • This update adds functionality inside the populate_network() function to remove the recovery_mode_clean_expired_keys cron event. Since Recovery Mode is not used in a Multisite environment, this cron event is no longer necessary. Removing it ensures that unnecessary scheduled tasks are not running.

Changes

  • Cron Event Removal: The following code has been added inside the populate_network() function to clear the recovery_mode_clean_expired_keys cron event if it's scheduled.

Why This Is Necessary

The recovery_mode_clean_expired_keys cron event is intended for cleaning expired recovery keys in single-site installations. It is not required in a Multisite environment, and clearing it ensures that unnecessary cron jobs are not scheduled, thus improving overall performance.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Debarghya-Banerjee
Copy link
Author

Hi @johnbillion , can you please take a look into this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant