Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix 'parents' argument validation for Query block #8245

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Feb 3, 2025

Gutenberg PR: WordPress/gutenberg#68983
Trac ticket: https://core.trac.wordpress.org/ticket/62901


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@Mamaduka Mamaduka self-assigned this Feb 3, 2025
@Mamaduka Mamaduka requested a review from audrasjb February 3, 2025 15:00
Copy link

github-actions bot commented Feb 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mamaduka, audrasjb, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 3, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc
Copy link
Contributor

This looks good to me, I used the following to test it against trunk and this branch and it now behaves as expected. Are you able to put this in to the test suite?

/**
 * @ticket 62901
 */
public function test_build_query_vars_from_query_block_with_top_level_parent() {
	$this->registry->register(
		'core/example',
		array( 'uses_context' => array( 'query' ) )
	);

	$parsed_blocks = parse_blocks( '<!-- wp:example {"ok":true} -->a<!-- wp:example /-->b<!-- /wp:example -->' );
	$parsed_block  = $parsed_blocks[0];
	$context       = array(
		'query' => array(
			'postType' => 'page',
			'parents'  => array( 0 ),
		),
	);
	$block         = new WP_Block( $parsed_block, $context, $this->registry );
	$query         = build_query_vars_from_query_block( $block, 1 );

	$this->assertSame(
		array(
			'post_type'       => 'page',
			'order'           => 'DESC',
			'orderby'         => 'date',
			'post__not_in'    => array(),
			'tax_query'       => array(),
			'post_parent__in' => array( 0 ),
		),
		$query
	);
}

@Mamaduka
Copy link
Member Author

Mamaduka commented Feb 4, 2025

Thank you, @peterwilsoncc!

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset and the related unit tests look good to me 👍

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 4, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 4, 2025
@Mamaduka
Copy link
Member Author

Mamaduka commented Feb 4, 2025

@Mamaduka Mamaduka closed this Feb 4, 2025
@Mamaduka Mamaduka deleted the fix/query-loop-parents-argument-validation branch February 4, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants