Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#63052 Unblock the upgrade pre-flight check on WordPress < 5.1 #8457

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/upgrade-develop-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,17 @@ jobs:
php: [ '7.2', '8.4' ]
db-type: [ 'mysql' ]
db-version: [ '5.7', '8.4' ]
wp: [ '6.5', '6.6', '6.7' ]
# WordPress 4.9 is the oldest version that supports PHP 7.2.
wp: [ '4.9', '6.5', '6.6', '6.7' ]
multisite: [ false, true ]

exclude:
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
- php: '7.2'
db-version: '8.4'
# WordPress 4.9 does not support PHP 8.4.
- php: '8.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://make.wordpress.org/hosting/handbook/compatibility/ WP 4.9 also only supports MySQL up to 5.7.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct but it does work despite not being officially supported. The PHP 8.4 test needs to be excluded because the site exits with a fatal error due to the use of get_magic_quotes_gpc() in 4.9.

wp: '4.9'
with:
os: ${{ matrix.os }}
php: ${{ matrix.php }}
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/update-core.php
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,7 @@ function update_core( $from, $to ) {
}

// Add a warning when required PHP extensions are missing.
if ( $missing_extensions->has_errors() ) {
if ( ! empty( $missing_extensions->errors ) ) {
return $missing_extensions;
}
}
Expand Down
Loading