-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent empty author links in Posts list tables #8488
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Testing Instructions
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
QA Test ReportI tested this PR using the following query to reset the author:
After running the query and removing the author from the post, I noticed that a dash (-) sign appears in place of the author name. Testing Environment
|
Trac ticket: https://core.trac.wordpress.org/ticket/62913
Description:
This PR addresses an issue in the Posts List Table where posts without an assigned author display an empty author column. A similar fix is already applied to the Media List Table (#8271), but the issue also affects other list tables.
Changes Made
• Added a fallback text (— no author) when
get_the_author()
returns an empty string.• Ensured
get_the_author_meta( 'ID' )
is only used whenget_the_author()
is not empty, preventing invalid author links.• Mirrors the approach taken in the Media List Table fix for consistency.
This aligns with feedback from @joedolson on https://core.trac.wordpress.org/ticket/62913#comment:5, where he suggested extending the fix to all list tables, not just the Media List Table.
Testing Instructions
Check the comment below.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.