Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Dependabot workflows for private mirrors #8576

Closed

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Mar 24, 2025

Currently, the if conditionals for workflows use one of two approaches to limit when they run: Run if the repository is WordPress/wordpress-develop OR if the workflow is triggered by a pull_request event. This prevents workflows from running needlessly on forks and mirrors when branches are synced or updated through push events, but still allows contributors to open PRs back to their forks to test changes before submitting them back.

This can cause some issues with Dependabot, though. Dependabot is disabled by default for all forks. However, it is impossible to disable Dependabot for mirrors when a dependabot.yml file is present. This is especially problematic for private mirrors, which consume resources for organizations.

This switches the OR condition to run workflows if triggered by a pull_request AND the actor is not dependabot to prevent these workflows from running in this situation.

Trac ticket: https://core.trac.wordpress.org/ticket/62221


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj requested a review from johnbillion March 24, 2025 23:29
@desrosj desrosj self-assigned this Mar 24, 2025
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj requested a review from swissspidy March 25, 2025 10:26
@desrosj
Copy link
Contributor Author

desrosj commented Mar 25, 2025

@desrosj desrosj closed this Mar 25, 2025
@desrosj desrosj deleted the gha/disable-dependabot-in-forks branch March 25, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants