Feature/mvp #1
Feature/mvp #1
Conversation
index_countdown.html
Outdated
| @@ -3,15 +3,16 @@ | |||
| <head> | |||
| <!-- ## SITE META ## --> | |||
| <meta charset="utf-8"> | |||
| <title>Eventicka II</title> | |||
| <title>2016 Write/Speak/Code Conference</title> | |||
There was a problem hiding this comment.
This is why code reviews are a good thing ❤️
jarmstrng
force-pushed
the
feature/mvp
branch
from
3efa142 to
e7744ce
Compare
- Replaced all qcSposnsorList with qsSponsorList
- Include rgb and hex references at the top of custom.css - Replace colors in custom.css with brand colors
- Surround countdown area in a div to set background - Comment out css that was fixing styles and background to body of home page - Add sponsors to the nav bar as an anchor link
| } | ||
| #qcHeader { | ||
| border-top-color: #1DB6AD; | ||
| } | ||
| body.home:after { |
There was a problem hiding this comment.
Just curious: why was body.home:after { removed?
| @@ -185,7 +185,7 @@ body { | |||
|
|
|||
| /* === 3.1 HOME BODY === */ | |||
|
|
|||
| body.home { | |||
| /*body.home { | |||
There was a problem hiding this comment.
If you think that we'll need this later, can you add comments as to why you commented this out? OR if you don't think we'll need it, just nuke it :)
There was a problem hiding this comment.
@jarmstrng I commented it out because I thought it made more sense to do that than override all these settings in custom.css, but I didn't delete because I didn't want to alter style.css. In the original design, there was nothing below the countdown so the css fixing the screen was on .body.home.static. Which is why since we are doing single page app I thought it made more sense to put the countdown into it's own section and put styles on that section instead of the body.
There was a problem hiding this comment.
Makes sense. I did have to change something in order to get the new font to work for the subhead and I wonder if removing this altered the specificity-ness of the override coming from custom.css. We might have to keep an eye on styling to make sure this change wasn't what caused the issue (I was able to change the font without the extra change in one commit, but not a different commit. Wasn't obvious why it wouldn't work but now I'm wondering.... 😝 )
| <div class="box"> | ||
| <h4>Navigation</h4> | ||
| <ul id="qcPriNav"> | ||
| <li class="active"><a href="index.html">Home</a></li> |
There was a problem hiding this comment.
Can you rename the index_countdown.html file to index.html? That should fix this link, and reflect the fact that we have only one index page :)
| <h4>Navigation</h4> | ||
| <ul id="qcPriNav"> | ||
| <li class="active"><a href="index.html">Home</a></li> | ||
| <li><a href="#sponsors">Sponsors</a></li> |
There was a problem hiding this comment.
Clicking this link doesn't close the modal, but adding onclick="$('#qcSiteNav').fadeOut()" will make it work. Bonus points if you can think of some way to make that nice and DRY for all the other (future) links in the nav 😂
We might not stick with this hamburger menu, but let's create a separate story if we decide we want that change
index_countdown.html
Outdated
| @@ -66,7 +66,7 @@ | |||
|
|
|||
| <!-- ## SLIDE TEXT ## --> | |||
| <div id="qcSlideText"> | |||
| <h1 id="slidecaption">Write/Speak/Code 2017 is here</h1> | |||
| <h1 id="slidecaption">Write/Speak/Code 2017 conference is here</h1> | |||
There was a problem hiding this comment.
Lateesha would also like us to remove the words "is here" to the header
index_countdown.html
Outdated
| @@ -66,7 +66,7 @@ | |||
|
|
|||
| <!-- ## SLIDE TEXT ## --> | |||
| <div id="qcSlideText"> | |||
| <h1 id="slidecaption">Write/Speak/Code 2017 is here</h1> | |||
| <h1 id="slidecaption">Write/Speak/Code 2017 conference is here</h1> | |||
| <p id="slidedesc">Join us for 4 intense days of workshops, seminars, and talks. Let's build the blueprint that will take your career to the next level!</p> | |||
There was a problem hiding this comment.
And add a <br> or something so that each of these sentences is on a separate line
No description provided.