refactor: Clio Config #1593
refactor: Clio Config #1593
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1593 +/- ##
===========================================
+ Coverage 69.61% 70.06% +0.45%
===========================================
Files 257 265 +8
Lines 9879 10175 +296
Branches 5457 5612 +155
===========================================
+ Hits 6877 7129 +252
- Misses 1588 1601 +13
- Partials 1414 1445 +31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Maybe we can just use one general constraint to constraint the port range, api range, instead of creating different constraint for each usage. For logger channels and levels, we can use one constraint (like OneOf) . I saw the similarity between the config constraint and the input validators, worth to check if anything we can borrow from validators.
|
@godexsoft Just a heads-up: I removed the uint64 constraint since, in the places where it's used, the user only inputs a number in the thousands, and we multiply that number by a constant. Therefore, I really don't think the uint64 constraint is necessary |
Add constraint + parse json into Config Second part of refactoring Clio Config; First PR found [here](#1544) Steps that are left to implement: - Replacing all the places where we fetch config values (by using config.valueOr/MaybeValue) to instead get it from Config Definition - Generate markdown file using Clio Config Description
Add constraint + parse json into Config
Second part of refactoring Clio Config; First PR found here
Steps that are left to implement: