Update conanfile.py #1648
Open
Update conanfile.py #1648
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godexsoft
requested changes
Sep 16, 2024
| @@ -21,20 +20,8 @@ class Clio(ConanFile): | |||
| 'lint': [True, False], # run clang-tidy checks during compilation | |||
| } | |||
|
|
|||
| requires = [ | |||
There was a problem hiding this comment.
This block should stay as it was. Other than that the pr looks ok to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
fPICOption:We took out the
fPICoption from both theoptionsanddefault_optionssections because it wasn’t being used in your configuration.Updated Dependency Options: We added a specific setting for the
benchmarkdependency in thedefault_optionssection. This setsbenchmark/*:header_onlytoTrue, assuming this is the right configuration for your setup.Cleaned Up Comments:
We updated and cleaned up comments to make sure they accurately reflect the changes and provide clearer explanations where needed.
General Cleanup: We did some tidying up by removing unnecessary mentions and placeholder comments that were left over after removing the
fPICoption.