Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XrpCurrencyAmount#toString to emit pseudo-JSON #547

Open
sappenin opened this issue Aug 21, 2024 · 0 comments
Open

Update XrpCurrencyAmount#toString to emit pseudo-JSON #547

sappenin opened this issue Aug 21, 2024 · 0 comments
Labels
breaking Introduces a breaking change from one version to the next.

Comments

@sappenin
Copy link
Collaborator

The toString function in XrpCurrencyAmount emits a numeric value that represents the current number of drops. However, this is somewhat askew from typical Immutables handling of objects. In addition, this does not align with the format that the sibling IssuedCurrencyAmount is using for its toString.

Thus, in a future version of xrpl4, we should change this implementation to emit a more typica object-like String.
@sappenin sappenin added the breaking Introduces a breaking change from one version to the next. label Aug 21, 2024
@sappenin sappenin mentioned this issue Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Introduces a breaking change from one version to the next.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sappenin