-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #474 #535
Merged
Merged
Fixes #474 #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappenin
commented
May 20, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Wrappers.java
Outdated
Show resolved
Hide resolved
sappenin
commented
May 20, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Wrappers.java
Outdated
Show resolved
Hide resolved
sappenin
commented
May 20, 2024
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/IssuedCurrencyAmountTest.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
============================================
+ Coverage 91.92% 91.99% +0.06%
- Complexity 1823 1831 +8
============================================
Files 381 381
Lines 5040 5082 +42
Branches 417 431 +14
============================================
+ Hits 4633 4675 +42
+ Misses 273 272 -1
- Partials 134 135 +1 ☔ View full report in Codecov by Sentry. |
nkramer44
approved these changes
Jun 8, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Wrappers.java
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Wrappers.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/IssuedCurrencyAmountTest.java
Show resolved
Hide resolved
- Update code comments.
sappenin
commented
Aug 22, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/AmountType.java
Outdated
Show resolved
Hide resolved
sappenin
commented
Aug 22, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/AmountType.java
Show resolved
Hide resolved
sappenin
commented
Aug 22, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/AmountType.java
Show resolved
Hide resolved
nkramer44
reviewed
Aug 22, 2024
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Wrappers.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/AmountType.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/AmountType.java
Outdated
Show resolved
Hide resolved
…mountType.java Co-authored-by: nkramer44 <[email protected]>
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #474 by adding the
isNegative
functionCurrencyAmount
, and then properly supporting negative value detection in XRP and IssuedCurrency amounts.This fix should also fix issue #527.