Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #474 #535

Merged
merged 23 commits into from
Aug 23, 2024
Merged

Fixes #474 #535

merged 23 commits into from
Aug 23, 2024

Conversation

sappenin
Copy link
Collaborator

Fixes #474 by adding the isNegative function CurrencyAmount, and then properly supporting negative value detection in XRP and IssuedCurrency amounts.

This fix should also fix issue #527.

Fixes #474 by adding the `isNegative` function `CurrencyAmount`, and then properly supporting negative value detection in XRP and IssuedCurrency amounts.

This fix should also fix issue #527.
@sappenin sappenin added the bug Something isn't working label May 20, 2024
@sappenin sappenin requested a review from nkramer44 May 20, 2024 22:34
@sappenin sappenin self-assigned this May 20, 2024
@sappenin sappenin requested a review from nhartner as a code owner May 20, 2024 22:34
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.99%. Comparing base (2f07675) to head (d2c6596).
Report is 1 commits behind head on main.

Files Patch % Lines
...org/xrpl/xrpl4j/codec/binary/types/AmountType.java 88.88% 0 Missing and 2 partials ⚠️
...a/org/xrpl/xrpl4j/model/transactions/Wrappers.java 95.12% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #535      +/-   ##
============================================
+ Coverage     91.92%   91.99%   +0.06%     
- Complexity     1823     1831       +8     
============================================
  Files           381      381              
  Lines          5040     5082      +42     
  Branches        417      431      +14     
============================================
+ Hits           4633     4675      +42     
+ Misses          273      272       -1     
- Partials        134      135       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappenin sappenin removed the request for review from nhartner August 23, 2024 20:13
@sappenin sappenin merged commit a1669af into main Aug 23, 2024
21 checks passed
@sappenin sappenin deleted the df/474-fix-negative-xrpamount branch August 23, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LedgerResult Deserialization: Negative Balance in AccountRoot AffectedNode
2 participants