correctly handle isolation scope of 'placeholder' attribute, fixed dn…

…auck#15
XiXora · Jul 13, 2015 · 990d1b4 · 990d1b4
1 parent 8e891ef
commit 990d1b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 * change main proeprty of package.json to final build in dist folder, fixes #4
 * use ng-if for search parameter input to avoid rendering issues and performance
 * Hide in use search parameter suggestions, fixed issue #8
+* correctly handle isolation scope of 'placeholder' attribute, fixed #15
 
 ### 1.1.1 - 03 February 2015
 * update README with latest changes to dist files in bower package

diff --git a/src/angular-advanced-searchbox.js b/src/angular-advanced-searchbox.js
@@ -16,15 +16,16 @@ angular.module('angular-advanced-searchbox', [])
             restrict: 'E',
             scope: {
                 model: '=ngModel',
-                parameters: '='
+                parameters: '=',
+                placeholder: '@'
             },
             replace: true,
             templateUrl: 'angular-advanced-searchbox.html',
             controller: [
                 '$scope', '$attrs', '$element', '$timeout', '$filter',
                 function ($scope, $attrs, $element, $timeout, $filter) {
 
-                    $scope.placeholder = $attrs.placeholder || 'Search ...';
+                    $scope.placeholder = $scope.placeholder || 'Search ...';
                     $scope.searchParams = [];
                     $scope.searchQuery = '';
                     $scope.setSearchFocus = false;