Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 do not compare types error #716

Closed

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented Oct 26, 2023

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added
  • Docs have been added / updated
  • All CI checks are green
  • What kind of change does this PR introduce?
    Build fix
  • What is the current behavior?
    Running tox -e py39 or pre-commit run --all-files leads to a flake8 failure:

    detect_secrets/plugins/ibm_cloud_iam.py:37:8: E721 do not compare types, for exact checks use `is` / `is not`, for 
    instance checks use `isinstance()`
    
  • What is the new behavior (if this is a feature change)?
    flake8 passes. For example:

    (.venv)
    abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/detect-secrets (fix-flake8-do-not-compare-types-error●)
    $ pre-commit run --all-files
    Check builtin type constructor use.......................................Passed
    Check docstring is first.................................................Passed
    Debug Statements (Python)................................................Passed
    Fix double quoted strings................................................Passed
    Fix End of Files.........................................................Passed
    Tests should end in _test.py.............................................Passed
    Flake8...................................................................Passed
    Trim Trailing Whitespace.................................................Passed
    Reorder python imports...................................................Passed
    Add trailing commas......................................................Passed
    autopep8.................................................................Passed
    Detect secrets...........................................................Passed
    
  • Does this PR introduce a breaking change?
    No

  • Other information:

@lorenzodb1
Copy link
Member

Addressed in #724

@lorenzodb1 lorenzodb1 closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants