Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not identifying all Github token occurrences in a file Issue #858 #859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karamuz
Copy link

@karamuz karamuz commented Jun 20, 2024

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added
  • Docs have been added / updated
  • All CI checks are green
  • What kind of change does this PR introduce?
    Fixes behavior on identifying multiple Github tokens in the same file.

  • What is the current behavior?
    Issue: #858

  • What is the new behavior (if this is a feature change)?
    finditer() yields match objects from which you can extract the entire match (via match.group(0)), providing flexibility and precision in handling regex matches.

  • Does this PR introduce a breaking change?
    No.

@karamuz karamuz changed the title Fix not identifying all Github token occurrences in a file Yelp#858 Fix not identifying all Github token occurrences in a file Issue #858 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant