-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set value for uses_bulkdata_default to False #4009
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we don't anticipate ever changing this default again, i'd say we could further clean this up and hardcode the default to false
(also, looks like there's some tests that were expecting the previous default) |
I don't know if we actually expect these to bounce because now the config should match reality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nemacysts the plan is to loop back and remove this once we've removed defaults from puppet in https://github.yelpcorp.com/sysgit/puppet/pull/13980 - but doing that without this change would cause a big bounce
@timmow sorry, I meant that we could get rid of |
This changes the default value of uses_bulkdata to false, meaning that we can then remove the puppet hiera value which makes the default false that way. Everywhere that puppet is installed has a default value of False, so this shouldn't require a big bounce.