Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set value for uses_bulkdata_default to False #4009

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SuperMatt
Copy link
Contributor

This changes the default value of uses_bulkdata to false, meaning that we can then remove the puppet hiera value which makes the default false that way. Everywhere that puppet is installed has a default value of False, so this shouldn't require a big bounce.

timmow
timmow previously approved these changes Feb 24, 2025
nemacysts
nemacysts previously approved these changes Feb 24, 2025
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't anticipate ever changing this default again, i'd say we could further clean this up and hardcode the default to false

@nemacysts
Copy link
Member

(also, looks like there's some tests that were expecting the previous default)

@SuperMatt SuperMatt dismissed stale reviews from nemacysts and timmow via c1f1ccc February 25, 2025 08:15
I don't know if we actually expect these to bounce because now the config should match reality.
Copy link
Member

@timmow timmow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemacysts the plan is to loop back and remove this once we've removed defaults from puppet in https://github.yelpcorp.com/sysgit/puppet/pull/13980 - but doing that without this change would cause a big bounce

@nemacysts
Copy link
Member

the plan is to loop back and remove this once we've removed defaults from puppet in https://github.yelpcorp.com/sysgit/puppet/pull/13980 - but doing that without this change would cause a big bounce

@timmow sorry, I meant that we could get rid of get_uses_bulkdata_default() and replace any calls to that with False - then the puppet code can be removed without needing to come back to this file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants