Don't overwrite hooks without --force #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `bark install` silently overwrites any `reference-transaction` hook that may be present. This is a potentially very destructive action, so we should take proper care before doing so. I don't think there's a good way to automatically resolve the conflict in case the file already exists, so this implementation simply lists the conflicting files and leaves it to the user to resolve the conflict manually. (For example, we could move both hook files into `hooks/reference-transaction.d/` and make `hooks/reference-transaction` a script that calls all scripts in `reference-transaction.d/`, but it's not obvious that things like order of execution wouldn't matter.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
bark installsilently overwrites anyreference-transactionhook that may be present. This is a potentially very destructive action, so we should take proper care before doing so.I don't think there's a good way to automatically resolve the conflict in case the file already exists, so this implementation simply lists the conflicting files and leaves it to the user to resolve the conflict manually. (For example, we could move both hook files into
hooks/reference-transaction.d/and makehooks/reference-transactiona script that calls all scripts inreference-transaction.d/, but it's not obvious that things like order of execution wouldn't matter.)