Skip to content

Commit

Permalink
fix(Application): Fix base-path not being considered for popup dialogs
Browse files Browse the repository at this point in the history
  • Loading branch information
a11delavar committed May 15, 2024
1 parent 900d1e8 commit 3f7643b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/Application/Dialog/PageDialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@ import { component, eventListener, HTMLTemplateResult, state, staticHtml } from
import { PageComponent } from '../Page/PageComponent.js'
import { route } from '../Router/route.js'
import { DialogComponent } from './DialogComponent.js'
import { Router } from '../Router/Router.js'

@route(PageDialog.route)
@component('lit-page-dialog')
export class PageDialog extends PageComponent {
static readonly route = '/dialog'
static readonly route = `${Router.basePath}/dialog`

@state() heading = ''

Expand Down
2 changes: 1 addition & 1 deletion packages/Application/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@a11d/lit-application",
"version": "0.2.3",
"version": "0.2.4",
"description": "Lit-based application shell.",
"repository": {
"type": "git",
Expand Down

0 comments on commit 3f7643b

Please sign in to comment.