Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(mmu): add overflow handling #452

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

4rgon4ut
Copy link

@4rgon4ut 4rgon4ut commented Sep 12, 2024

Closes: #395

@4rgon4ut
Copy link
Author

4rgon4ut commented Sep 12, 2024

I feel I need to get an acknowledgement for my direction as Im new to the codebase @moodlezoup.

  1. Memory model:
image

Thus every attempt to write to zero_padding addresses is stack overflow and all writes over DRAM_BASE + memory.capacity is heap overflow. Is that correct?

  1. It would be also nice to have sort of example program to face this cases in runtime. Is that something you would like to see?

  2. store_raw() have no tracer call before actual operation, should I add checks in *_raw() functions?

@moodlezoup
Copy link
Collaborator

I feel I need to get an acknowledgement for my direction as Im new to the codebase @moodlezoup.

  1. Memory model:
image Thus every attempt to write to `zero_padding` addresses is stack overflow and all writes over `DRAM_BASE + memory.capacity` is heap overflow. Is that correct?

Yes this is correct

  1. It would be also nice to have sort of example program to face this cases in runtime. Is that something you would like to see?

Yes, it would be great to have a test for this feature

  1. store_raw() have no tracer call before actual operation, should I add checks in *_raw() functions?

I think so, but I haven't looked at that code in a while so if there's a better place to add the checks, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better errors for insufficient stack or memory size
2 participants