Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.10.7: fix REPLACEMENT COUNT + bugfix DELETE internal #1454

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Conversation

larshp
Copy link
Member

@larshp larshp commented Aug 5, 2024

@larshp larshp changed the title wip bugfix REPLACE Aug 5, 2024
@larshp larshp changed the title bugfix REPLACE 2.10.7: bugfix REPLACE Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Regression test results:

Repository Result
abap-openapi/abap-openapi 🟢
abapGit/abapGit 🟢
dominikpanzer/cacamber-BDD-for-ABAP 🟢
heliconialabs/abap-opentelemetry 🟢
heliconialabs/abap-protobuf 🟢
larshp/abap-advent-2020 🟢
larshp/abap-wasm 🟢
larshp/abapNTLM 🟢
larshp/abapPGP 🟢
open-abap/open-abap-core 🟢
open-abap/open-abap-gui 🟢
open-abap/open-abap-odata 🟢
open-abap/open-table-maintenance 🟢
SAP/abap-file-formats-tools 🟢
Sumu-Ning/AES 🟢

Performance test results:

Performance Before After Delta
1: APPEND and DELETE 1132ms 1075ms -57 🟢
2: READ TABLE, table_line 1005ms 997ms -8 🟢
3: LOOP USING KEY 1097ms 1118ms 21 🟢
4: Copy, same sorting 244ms 235ms -9 🟢
5: Copy, becomes sorted 92ms 100ms 8 🟢
6: INSERT INDEX 1 432ms 436ms 4 🟢
7: APPEND matching types 1010ms 1015ms 5 🟢
8: READ TABLE BINARY SEARCH 85ms 77ms -8 🟢
9: INSERT INTO TABLE hashed 22ms 22ms 0 🟢
10: DELETE ADJACENT 1500ms 1492ms -8 🟢
11: READ WITH TABLE KEY HASHED 320ms 323ms 3 🟢
12: READ WITH KEY HASHED, primary 405ms 395ms -10 🟢
13: INSERT INTO TABLE standard 65ms 65ms 0 🟢
14: Constant characters 121ms 118ms -3 🟢
15: Compare characters 110ms 104ms -6 🟢
16: Method number 5 🎶 790ms 789ms -1 🟢
17: Substring and find negative 278ms 282ms 4 🟢
18: CO compare 225ms 217ms -8 🟢
19: Call method, compatible structure 393ms 406ms 13 🟢
20: Call method, identical structure 16ms 18ms 2 🟢
21: CASE many char constants 495ms 561ms 66 🟢
22: READ TABLE WITH KEY secondary 56ms 53ms -3 🟢
23: CASE many int constants 353ms 344ms -9 🟢
24: Copy table contents 1326ms 1300ms -26 🟢
25: READ TABLE, not found 44ms 44ms 0 🟢
26: REPLACE OCCURRENCES, simple 153ms 144ms -9 🟢
27: READ TABLE, building hash 93ms 88ms -5 🟢
28: CONCATENATE 3ms 2ms -1 🟢
29: Write Hex to Hex via offset 2669ms 2648ms -21 🟢
30: Get Hex from Hex via offset 8ms 8ms 0 🟢
31: SET BIT hex 1243ms 1370ms 127 🟢
32: GET BIT hex 1027ms 927ms -100 🟢
33: Compare Hex 829ms 858ms 29 🟢
34: Basic CONCATENATE 79ms 80ms 1 🟢
35: gt 340ms 327ms -13 🟢

Updated: 2024-08-05T16:59:31.506Z

SHA: e6a0d60

@larshp larshp changed the title 2.10.7: bugfix REPLACE 2.10.7: fix REPLACEMENT COUNT Aug 5, 2024
@larshp larshp changed the title 2.10.7: fix REPLACEMENT COUNT 2.10.7: fix REPLACEMENT COUNT + bugfix DELETE Aug 5, 2024
@larshp larshp changed the title 2.10.7: fix REPLACEMENT COUNT + bugfix DELETE 2.10.7: fix REPLACEMENT COUNT + bugfix DELETE internal Aug 5, 2024
@larshp larshp marked this pull request as ready for review August 5, 2024 17:05
@larshp larshp merged commit 6ef00bb into main Aug 5, 2024
5 checks passed
@larshp larshp deleted the hvam/replace0508 branch August 5, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant