Fix bug that list item failed to keep original order and dict item failed to save its all items #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… item in json failed to save its all items
for example, the json I want to save via django form as below:
{
"FAT": {
"TARS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CMS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CDPortal": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
},
"UAT": {
"TARS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CMS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CDPortal": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
},
"PROD": {
"TARS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CMS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CDPortal": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
},
"TEST": {
"TARS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CMS": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
"CDPortal": {"application": [True, ""], "group": [True, ""], "server": [True, ""]},
},
}
after saved, the json changed as below:
{
'FAT': {'CMS': {'group': ['True', '']}},
'PROD': {'CDPortal': {'group': ['True', '']}},
'TEST': {'TARS': {'server': ['', 'True']}},
'UAT': {'CDPortal': {'server': ['', 'True']}}
}
there are two issues this patch to fix:
1. value of json_obj['UAT']['CDPortal']['server'] should be ['True',
''], not ['', 'True'] # order changed
2. once item in json_obj is a dict, like json['FAT'], it should have 3
items ('TARS', 'CMS', 'CDPortal'), but only one item saved.
Since OrderedDict is not a build-in lib in python 2.6.9, last commit can not pass the ci verification. this commit removed the dependency of OrderedDict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example, the json object I want to save via django form as below:
after saved, the json changed as below:
there are two issues this patch to fix:
json_obj['UAT']['CDPortal']['server']should be['True', ''], not['', 'True']# order changedjson_obj['FAT'], it should have 3items ('TARS', 'CMS', 'CDPortal'), but only one item saved.