Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for modifying and creating data #4373

Draft
wants to merge 25 commits into
base: python-dev
Choose a base branch
from

Conversation

mbollmann
Copy link
Member

This PR develops still missing functionality for modifying existing data as well as ingesting new proceedings.

When done, will close #4338.

@mbollmann mbollmann added the python-library Concerning the acl-anthology-py library label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 93.62187% with 28 lines in your changes missing coverage. Please review.

Project coverage is 92.32%. Comparing base (dfda10f) to head (9905769).
Report is 1 commits behind head on python-dev.

Files with missing lines Patch % Lines
python/acl_anthology/collections/paper.py 91.91% 8 Missing ⚠️
python/acl_anthology/utils/attrs.py 88.52% 7 Missing ⚠️
python/acl_anthology/collections/bibkeys.py 93.33% 4 Missing ⚠️
python/acl_anthology/collections/collection.py 89.65% 3 Missing ⚠️
python/acl_anthology/collections/volume.py 91.17% 3 Missing ⚠️
python/acl_anthology/collections/event.py 97.36% 1 Missing ⚠️
python/acl_anthology/collections/index.py 94.44% 1 Missing ⚠️
python/acl_anthology/text/stopwords.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           python-dev    #4373      +/-   ##
==============================================
- Coverage       92.56%   92.32%   -0.25%     
==============================================
  Files              32       35       +3     
  Lines            2301     2566     +265     
==============================================
+ Hits             2130     2369     +239     
- Misses            171      197      +26     
Files with missing lines Coverage Δ
python/acl_anthology/anthology.py 89.40% <100.00%> (+0.36%) ⬆️
python/acl_anthology/collections/__init__.py 100.00% <100.00%> (ø)
python/acl_anthology/collections/eventindex.py 96.00% <100.00%> (ø)
python/acl_anthology/collections/types.py 100.00% <100.00%> (ø)
python/acl_anthology/constants.py 100.00% <100.00%> (ø)
python/acl_anthology/containers.py 96.26% <100.00%> (ø)
python/acl_anthology/exceptions.py 96.00% <ø> (ø)
python/acl_anthology/files.py 98.78% <100.00%> (ø)
python/acl_anthology/people/index.py 83.73% <100.00%> (ø)
python/acl_anthology/people/name.py 98.55% <100.00%> (+0.02%) ⬆️
... and 18 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-library Concerning the acl-anthology-py library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant