Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authnet: Parse card_type from response #3218

Closed

Conversation

dingels35
Copy link

When creating a new ActiveMerchant::Billing::Response, the AuthorizeNetGateway does not populate params with all of the data that is returned in Authorize.net's XML response.

One of the missing fields is card_type. This PR follows the convention in AuthorizeNetGateway to add that value.

% rake test:units
Finished in 9.844451 seconds.
------------------------------------------------------------------------------------------------------------------------
4056 tests, 69070 assertions, 0 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------
412.01 tests/s, 7016.14 assertions/s
% rake test:remote TEST=test/remote/gateways/remote_authorize_net_test.rb
Finished in 61.416603 seconds.
------------------------------------------------------------------------------------------------------------------------
69 tests, 238 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------
1.12 tests/s, 3.88 assertions/s

@dingels35 dingels35 closed this May 16, 2019
@dingels35
Copy link
Author

Included in #3224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant