-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huma H/C17/Sharks #100
base: master
Are you sure you want to change the base?
Huma H/C17/Sharks #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your site looks very nice! Glad you got some practice in with Grid and Flexbox.
Nice job avoiding non semantic tags like div and span for styling. I think your HTML is appropriately structured and the semantic meaning is there!
Whenever you have the chance to revisit frontend development here's a great list of different resources to check out:
https://dev.to/nickytonline/frontend-developer-resources-2022-4cp2
🟢 for personal portfolio!
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Document</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to change this to something more descriptive since it'll show up in the tab of the browser
<p>My journey to becoming a full stack software engineer. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing tag can live on line 18 with the opening tag and content
<p>My journey to becoming a full stack software engineer. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing p tag can be on the same line as everything else here
<section class="sec-container"> | ||
<a href="https://github.com/hhameed1/viewing-party">VIEWING PARTY</a> | ||
<h3>A Python program to organize movies on your/friends watchlist</h3> | ||
<img src="../images/viewing-party.jpg" alt="hand scrolling through stacked VHS videos" style="width:250px"> | ||
<cite>Photo by Lucas Pezeta: https://www.pexels.com/photo/assorted-title-movie-case-lot-2398354/</cite> | ||
</section> | ||
<section class="sec-container"> | ||
<a href="https://github.com/hhameed1/swap-meet">SWAP MEET</a> | ||
<h3>This project utilizes object oriented programming, implementation of inheritance and tdd.</h3> | ||
<img src="../images/swap-meet.jpg" alt="variety of items in a thrift store" style="width:250px"> | ||
<cite>Photo by Roman Kraft: https://unsplash.com/photos/ChSJFIAEoRM</cite> | ||
</section> | ||
<section class="sec-container"> | ||
<a href="https://github.com/hhameed1/task-list-api">TASK LIST API</a> | ||
<h3>An API project that used SQL, Flask, external APIs and TDD.</h3> | ||
<img src="../images/tasklist-API.jpg" alt="checklist of items in a book" style="width:250px"> | ||
<cite>Photo by Polina Kovaleva: https://www.pexels.com/photo/white-notebook-on-the-table-5717425/</cite> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way you might see this HTML written is with an unordered list and each section element would be nested in a list item
<ul>
<li>
<section class="sec-container">
<a href="https://github.com/hhameed1/viewing-party">VIEWING PARTY</a>
<h3>A Python program to organize movies on your/friends watchlist</h3>
<img src="../images/viewing-party.jpg" alt="hand scrolling through stacked VHS videos" style="width:250px">
<cite>Photo by Lucas Pezeta: https://www.pexels.com/photo/assorted-title-movie-case-lot-2398354/</cite>
</section>
</li>
</ul>
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions