add support for 64bit WAVE files #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 24, 2020 10:23
try to solve git test build issue
|
Hi, |
added 4 commits
November 24, 2020 11:21
IEEE format preferred for saving 64bit WAVE files
cleaner cast
static cast necessary if T is float
the reinterpret_cast<int32_t&> will return the expected result only with a 32bit variable, so if T is double (64bit) it will not generate the right int32_t
|
Hi there, thanks for this pull request. It looks good - am I right in thinking that IEEEFloat can refer to either 32-bit or 64-bit encoding? Or is there a separate encoding flag for 64-bit floats? I will also need to write some unit tests for this too, but I'll try and do that soon :) |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.