Add AudioFile.h in cmake library interface #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'm really bad at cmake haha, so forgive me if my questions are stupid. Does the moving of the |
|
Before, USE_MATH_DEFINES was added in the main project, so somebody including the project would have a USE_MATH_DEFINES automatically added to their project when including the library. Now it is just added in the examples and tests project so it doesn't affect the library. Make sense ? |
|
Sorry, I thought you merged it into develop but finally it was just a 'change base branch from master to develop' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the AudioFile.h to the library, and cleaned up a couple other stuff.