Column resizing: handle coalesced pointer move events #3594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our column resize test are flaky in CI, which lead me to rethink this part of the codebase.
I think what's happening is that when we run the following code
playwright may not wait for pointer events to be dispatched before executing the next command,
so
mouse.up()
would run before the next render frame/before thepointermove
event is dispatched,so the
pointermove
event may be coalesced into thelostpointercapture
event.An alternative could be to add pauses between each mouse commands,
but handling the final pointer position does make sense, and is the right thing to do.
I couldn't reproduce the flaky test locally, so this is all theoretical.
https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents