This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
2.1.1 #25
Open
2.1.1 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address issue addthis#24 - addthis#24 .
Change version.
|
This pull request modifies a release version on the java8 branch. Is there any reason why this change should not be made on master? |
|
Dont see why not , I just needed it for a 2.1.0 branch . But it could be forward ported I guess :) . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address - #24
If the directory already exists then no metrics will gathered as we return false . This is understandable as you may not want to overwrite existing metrics .
The patch gets around this by renaming the existing directory to name+currentSystemtimeinmillis .
and then recreate the original directory .