Removed default context fallback #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costimuraru
reviewed
Oct 22, 2019
src/ops/cli/helmfile.py
Outdated
| if answer != "yes": | ||
| sys.exit() | ||
|
|
||
| logger.info('currently only eks type clusters supported') |
There was a problem hiding this comment.
Perhaps change this log message to warn/error?
|
@jewee can you please sign Adobe CLA Signed? or use @adobe.com account for the PR? |
costimuraru
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed default context fallback.
Description
Running directly against default kubernetes configured context has proven to be dangerous.
behaviour has improve after #84 was closed but after internal discusions it has been decided to remove running agains default kubernetes context altogether.
Running against non eks clusters will be added in the future by adding in ops the possibility to explicitly specify the context (#89).
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: