chore: update token colors in meter, illustrated message #7205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuiliao
commented
Oct 30, 2024
| // TODO: ask design about what the color should be. Says gray-800 in the designs file, neutral in token spec, but different neutral in dropzone spec | ||
| default: 'gray-800', | ||
| isInDropZone: 'gray-500', // neutral doesn't seem to match the color in designs, opted for gray-500 instead | ||
| default: 'neutral', |
There was a problem hiding this comment.
according to design, the illustration should have the same color both in an IllustratedMessage and in a DropZone. the design files do not currently reflect this but there are tickets to update them
yihuiliao
commented
Oct 30, 2024
| @@ -82,11 +82,11 @@ const fillStyles = style<MeterStyleProps>({ | |||
| borderStyle: 'none', | |||
| borderRadius: 'full', | |||
| backgroundColor: { | |||
| default: 'informative', | |||
| default: 'informative-visual', | |||
There was a problem hiding this comment.
matches what is in the design file. confirmed that the token accent-content-color-default which is listed in the token file is not correct with spectrum.
yihuiliao
changed the title
|
Have we run chromatic against this? |
|
link to chromatic |
snowystinger
approved these changes
Nov 1, 2024
reidbarber
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: