fix: testing session bugs treeview and tabs #7713
Merged
+336
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
yihuiliao
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
This fixes the Tab Panel layout in the Popover example in S2 and doesn't reinstate the requirement to utilize unsafe styles, as we had before. This should keep it closer to the original API. I'm still not 100% sold on it. I wish it were easier to make TabPanels auto-scroll regions by default, but we seem to need the flexibility afforded by not doing that.
It fixes the blue chevron and misaligned rows in iOS treeview s2.
Makes the external label for the tabs example a little more evident that that's what it is.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: