Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add autofill stories #7722

Merged
merged 7 commits into from
Feb 10, 2025
Merged

chore: add autofill stories #7722

merged 7 commits into from
Feb 10, 2025

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Feb 5, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

To test, you'll need to go to your browser's setting, find "Autofill", and save an address.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 5, 2025

@yihuiliao yihuiliao changed the title (wip) chore: add autofill stories chore: add autofill stories Feb 6, 2025
@yihuiliao yihuiliao marked this pull request as ready for review February 6, 2025 00:08
@rspbot
Copy link

rspbot commented Feb 6, 2025

}}>
<TextField>
<Label>Address</Label>
<Input name="streetAddress" type="text" id="streetAddress" autoComplete="shipping street-address" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh strange. it looks like it has autocomplete=""shipping address-level2" based on the screenshot. does it not autofill for you either?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, node above that one

Copy link
Member Author

@yihuiliao yihuiliao Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my b. that's really weird because it appears for me. it should be valid since i see an example of it in the mdn docs...it might be good to see if another person can reproduce

do you see this in other browsers as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, well, i updated chrome last night. now it's rendering. My Chrome autofill works on it, but my Dashlane doesn't recognize it for some reason still. At this point though, I think it's correct and I'm just running into local issues

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihuiliao yihuiliao added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit fb3b865 Feb 10, 2025
32 checks passed
@yihuiliao yihuiliao deleted the add-autofill-stories branch February 10, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants