-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated ignore pattern #3579
base: main
Are you sure you want to change the base?
Conversation
|
File metricsSummaryTotal size: 2.25 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise this works for me. Validated it locally.
🚀 Deployed on https://pr-3579--spectrum-css.netlify.app |
Our metadata.json files in component dist folders were being ignored even though we didn't want them to be. This was happening because the simple dist ignore rule was too broad and was overpowering our exception rule. Due to this husky/pre-commit was throwing error.
Updated the .gitignore to use more precise patterns:
**/dist/* # First ignore everything in any dist folder
!**/dist/metadata.json # Then make exception for metadata.json
*/dist/ - ignores contents of dist folders at any depth
The exception rule now properly matches the ignore pattern
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list