Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated ignore pattern #3579

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: updated ignore pattern #3579

wants to merge 4 commits into from

Conversation

blunteshwar
Copy link

@blunteshwar blunteshwar commented Feb 25, 2025

Our metadata.json files in component dist folders were being ignored even though we didn't want them to be. This was happening because the simple dist ignore rule was too broad and was overpowering our exception rule. Due to this husky/pre-commit was throwing error.
Updated the .gitignore to use more precise patterns:
**/dist/* # First ignore everything in any dist folder
!**/dist/metadata.json # Then make exception for metadata.json

*/dist/ - ignores contents of dist folders at any depth
The exception rule now properly matches the ignore pattern

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: 8357882

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@blunteshwar blunteshwar requested a review from pfulton February 25, 2025 04:34
Copy link
Contributor

github-actions bot commented Feb 25, 2025

File metrics

Summary

Total size: 2.25 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise this works for me. Validated it locally.

@castastrophe castastrophe added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

🚀 Deployed on https://pr-3579--spectrum-css.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants