-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(search): update disabled state in spectrum two #3593
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6cc7726 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3593--spectrum-css.netlify.app |
File metricsSummaryTotal size: 2.25 MB*
search
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
https://www.chromatic.com/test?appId=64762974a45b8bc5ca1705a2&id=67c57141bb87b246e02cabfd The changes that I did ended up affecting express theme for search - quiet and I haven't been able to figure out how to fix that :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Values resolve expected, but we'll need to generate an updated metadata.json
file by running yarn ci
.
components/search/themes/express.css
Outdated
@@ -23,6 +23,9 @@ | |||
--spectrum-search-border-color-focus-hover: var(--spectrum-gray-900); | |||
--spectrum-search-border-color-key-focus: var(--spectrum-gray-900); | |||
|
|||
--spectrum-search-background-color-disabled: var(--spectrum-disabled-background-color); | |||
--spectrum-search-border-color-disabled: var(--spectrum-disabled-background-color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--spectrum-search-border-color-disabled: var(--spectrum-disabled-background-color); | |
--spectrum-search-border-color-disabled: var(--spectrum-disabled-border-color); |
This might address the Chromatic diff you were seeing.
22f5d6f
to
6cc7726
Compare
Description
updated disabled search background color to gray-25 and border-color to gray-300 in spectrum-two theme.
SWC-574
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Include steps for the PR reviewer that explain how they should test your PR. Example test outline:
--system-search-background-color-disabled
now points to--spectrum-gray-25
. [@cdransf]--system-search-border-color-disabled
now points to--spectrum-gray-300
[@cdransf]Regression testing
Validate:
Screenshots
Old:


New:
To-do list