Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(search): update disabled state in spectrum two #3593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Mar 3, 2025

Description

updated disabled search background color to gray-25 and border-color to gray-300 in spectrum-two theme.
SWC-574

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Include steps for the PR reviewer that explain how they should test your PR. Example test outline:

  1. Open the storybook for the search component:
  • Verify that --system-search-background-color-disabled now points to --spectrum-gray-25. [@cdransf]
  • Verify that --system-search-border-color-disabled now points to --spectrum-gray-300 [@cdransf]

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Old:
Screenshot 2025-03-03 at 2 30 51 PM
New:
Screenshot 2025-03-03 at 2 31 02 PM

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@TarunAdobe TarunAdobe marked this pull request as ready for review March 3, 2025 06:38
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: 6cc7726

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/search Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 3, 2025

🚀 Deployed on https://pr-3593--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Mar 3, 2025

File metrics

Summary

Total size: 2.25 MB*

Package Size Minified Gzipped
search 11.70 KB 11.17 KB 1.88 KB

search

Filename Head Minified Gzipped Compared to base
index-base.css 10.40 KB 9.93 KB 1.75 KB 🟢 ⬇ 0.17 KB
index-theme.css 2.22 KB 2.15 KB 0.60 KB 🔴 ⬆ 0.18 KB
index.css 11.70 KB 11.17 KB 1.88 KB 🟢 ⬇ 0.04 KB
metadata.json 7.76 KB - - 🔴 ⬆ 0.08 KB
themes/express.css 2.04 KB 1.97 KB 0.63 KB 🔴 ⬆ 0.17 KB
themes/spectrum-two.css 1.90 KB 1.85 KB 0.59 KB 🔴 ⬆ 0.14 KB
themes/spectrum.css 1.96 KB 1.90 KB 0.60 KB 🔴 ⬆ 0.17 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@TarunAdobe TarunAdobe requested a review from a team March 3, 2025 09:01
@TarunAdobe
Copy link
Contributor Author

https://www.chromatic.com/test?appId=64762974a45b8bc5ca1705a2&id=67c57141bb87b246e02cabfd

The changes that I did ended up affecting express theme for search - quiet and I haven't been able to figure out how to fix that :(

Copy link
Member

@cdransf cdransf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values resolve expected, but we'll need to generate an updated metadata.json file by running yarn ci.

@@ -23,6 +23,9 @@
--spectrum-search-border-color-focus-hover: var(--spectrum-gray-900);
--spectrum-search-border-color-key-focus: var(--spectrum-gray-900);

--spectrum-search-background-color-disabled: var(--spectrum-disabled-background-color);
--spectrum-search-border-color-disabled: var(--spectrum-disabled-background-color);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--spectrum-search-border-color-disabled: var(--spectrum-disabled-background-color);
--spectrum-search-border-color-disabled: var(--spectrum-disabled-border-color);

This might address the Chromatic diff you were seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants