Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stepper): update default variant, key focus state in s2 #3594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Mar 3, 2025

Description

updated stepper Default variant, Key focus state border color to gray-800
swc-576

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  1. Open the storybook for the stepper component:
  • Verify that --spectrum-stepper-border-color-keyboard-focus points to --spectrum-gray-800

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link
Contributor

github-actions bot commented Mar 3, 2025

File metrics

Summary

Total size: 2.25 MB*

Package Size Minified Gzipped
stepper 18.36 KB 17.49 KB 2.41 KB

stepper

Filename Head Minified Gzipped Compared to base
index-base.css 16.67 KB 15.89 KB 2.27 KB -
index-theme.css 2.77 KB 2.69 KB 0.66 KB -
index.css 18.36 KB 17.49 KB 2.41 KB -
metadata.json 8.96 KB - - -
themes/express.css 2.06 KB 1.99 KB 0.65 KB -
themes/spectrum-two.css 2.23 KB 2.15 KB 0.64 KB -
themes/spectrum.css 2.23 KB 2.16 KB 0.65 KB -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

🚀 Deployed on https://pr-3594--spectrum-css.netlify.app

@TarunAdobe TarunAdobe requested a review from a team March 3, 2025 08:56
@cdransf
Copy link
Member

cdransf commented Mar 3, 2025

@TarunAdobe this resolves to --system-stepper-border-color-keyboard-focus which in turn resolves to --spectrum-gray-800 rather than a direct reference from the validation steps. Is that intended?

Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is helpful for the ticket, but I do have a draft PR that looks like it might address some of the states mentioned in SWC-576

https://github.com/adobe/spectrum-css/pull/3558/files

It may have some overlap with the states mentioned in the Jira ticket...maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This PR is just one small fix that we needed to align with the design team's version of s2 foundations for number-field. We'd want to get this in if possible soon.

@TarunAdobe
Copy link
Contributor Author

@TarunAdobe this resolves to --system-stepper-border-color-keyboard-focus which in turn resolves to --spectrum-gray-800 rather than a direct reference from the validation steps. Is that intended?

Yes! Thanks for pointing out. I intended to validate the final resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants