-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(stepper): update default variant, key focus state in s2 #3594
base: main
Are you sure you want to change the base?
Conversation
File metricsSummaryTotal size: 2.25 MB*
stepper
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
🚀 Deployed on https://pr-3594--spectrum-css.netlify.app |
@TarunAdobe this resolves to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is helpful for the ticket, but I do have a draft PR that looks like it might address some of the states mentioned in SWC-576
https://github.com/adobe/spectrum-css/pull/3558/files
It may have some overlap with the states mentioned in the Jira ticket...maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This PR is just one small fix that we needed to align with the design team's version of s2 foundations for number-field. We'd want to get this in if possible soon.
Yes! Thanks for pointing out. I intended to validate the final resolution. |
Description
updated stepper Default variant, Key focus state border color to gray-800
swc-576
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
--spectrum-stepper-border-color-keyboard-focus
points to--spectrum-gray-800
Regression testing
Validate:
Screenshots
To-do list