-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements to docs #5124
base: main
Are you sure you want to change the base?
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 13639262968Details
💛 - Coveralls |
Description
Improving the accessibility documentation of components.
Motivation and context
Documentation should provide more information and examples that demonstrate how to use the components accessibly. These changes started with #4652
How has this been tested?
<sp-action-button>
Review action button docs
<sp-action-bar>
Review action bar docs
<sp-action-group>
Review action group docs
<sp-action-menu>
Review action menu docs
<sp-asset>
Review asset docs
<sp-button>
Review button docs
<sp-button-group>
Review button group docs
<sp-card>
Review card docs
<sp-combobox>
Review combobox docs
<sp-help-text>
Review help text docs
<sp-icon>
Review icon docs
<sp-icons>
Review icons docs
<sp-iconset>
Review iconset docs
<sp-icons-ui>
Review icons-ui docs
<sp-icons-workflow>
Review icons-workflow docs
<sp-menu>
Review menu docs
<sp-menu-group>
Review menu-group docs
<sp-menu-item>
Review menu-item docs
<sp-picker>
Review picker docs
<sp-picker-button>
Review picker button docs
<sp-popover>
Review popover docs
<sp-slider>
Review slider docs
<sp-slider-handle>
Review slider handle docs
<sp-switch>
Review switch docs
<sp-tray>
Review tray docs
1. You can use the WAVE browser extension's Structure tab to review heading structure.
Developing a Component Guide
Overview tabs navigation fix
https://nikkimk-a11y-docs-ready--spectrum-web-components.netlify.app/components/card/api
?https://nikkimk-a11y-docs-ready--spectrum-web-components.netlify.app/components/card/
?https://nikkimk-a11y-docs-ready--spectrum-web-components.netlify.app/components/card/changelog
?https://nikkimk-a11y-docs-ready--spectrum-web-components.netlify.app/components/card/
?Font sizes
h1
: heading XXL, serif, heavyh2
: heading L, sans-serifh3
: heading M, sans-serifh4
: heading S, sans-serifh5
: detail Lbody
: body M, sans-serifTypes of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.