Updates project to use cloudflare-go

[KAllan357]

Hi!

This PR should address a few outstanding issues in the repo. Specifically, #76, #7, and #47.

After executing a pass against a few of the functions inside cloudflare_api.go, I decided that this could go all the way and essentially rewrite the whole file. My high level goal was to keep the API consistent, but adjust the functions so that they used cloudflare-go instead of the net/http package.

Please take a look when you get a chance.

[KAllan357]

@adyanth tagging you to see if you'd consider / review this PR.

[adyanth]

Hey @KAllan357 wow, thank you very much for the contribution! I was busy the last week, did not see this. Will review.

Edit: Looks like the CI build does not use the repo secrets for PRs. I'll go through it regardless.

[adyanth]

Comments with suggestions

[KAllan357]

Re-requested review. I'd like to try testing this, but I'm not 100% sure when I can get around to deploying a custom container with my changes.

[adyanth]

The makefile should allow you to build the container. No worries though, let me check it out. Will build and check before merging in. Otherwise, looks good! Thanks again for your contribution!

[KAllan357]

FWIW, make build does not seem to work on my machine. Maybe a separate issue to open?

go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-tools/cmd/[email protected]
go: added github.com/fatih/color v1.12.0
go: added github.com/go-logr/logr v0.4.0
go: added github.com/gobuffalo/flect v0.2.3
go: added github.com/gogo/protobuf v1.3.2
go: added github.com/google/go-cmp v0.5.6
go: added github.com/google/gofuzz v1.1.0
go: added github.com/inconshreveable/mousetrap v1.0.0
go: added github.com/json-iterator/go v1.1.11
go: added github.com/mattn/go-colorable v0.1.8
go: added github.com/mattn/go-isatty v0.0.12
go: added github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: added github.com/modern-go/reflect2 v1.0.1
go: added github.com/spf13/cobra v1.2.1
go: added github.com/spf13/pflag v1.0.5
go: added golang.org/x/mod v0.4.2
go: added golang.org/x/net v0.0.0-20210520170846-37e1c6afe023
go: added golang.org/x/sys v0.0.0-20210616094352-59db8d763f22
go: added golang.org/x/text v0.3.6
go: added golang.org/x/tools v0.1.5
go: added golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: added gopkg.in/inf.v0 v0.9.1
go: added gopkg.in/yaml.v2 v2.4.0
go: added gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
go: added k8s.io/api v0.22.2
go: added k8s.io/apiextensions-apiserver v0.22.2
go: added k8s.io/apimachinery v0.22.2
go: added k8s.io/klog/v2 v2.9.0
go: added k8s.io/utils v0.0.0-20210819203725-bdf08cb9a70a
go: added sigs.k8s.io/controller-tools v0.7.0
go: added sigs.k8s.io/structured-merge-diff/v4 v4.1.2
go: added sigs.k8s.io/yaml v1.2.0
/home/kallan/code/cloudflare-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
bash: /home/kallan/code/cloudflare-operator/bin/controller-gen: No such file or directory
make: *** [Makefile:80: generate] Error 127

[adyanth]

You need to have controller-gen installed and linked to that folder it mentions for kube builder to work.

Kind of a pain especially in macOS. Brew has it iirc.

https://book.kubebuilder.io/reference/controller-gen.html

[adyanth]

Tested it out. This should be all the necessary changes.

[KAllan357]

Thank you! I just batched all those suggestions up and committed them.