Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bridge_getTokenMappings endpoint #191

Merged
merged 29 commits into from
Feb 19, 2025
Merged

feat: bridge_getTokenMappings endpoint #191

merged 29 commits into from
Feb 19, 2025

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Feb 7, 2025 •
edited
Loading

Description

Expose the JSON RPC endpoint to retrieve the token mappings (bridge_getTokenMappings). It relies on indexing the NewWrappedToken event from the bridge contract, which is captured in the local SQL lite db.

The bridge_getTokenMappings provides the paginated token mapping results.

Fixes #190

@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/token-mappings-endpoint branch 2 times, most recently from 2b29cbf to 01eccc7 Compare February 12, 2025 08:08
@Stefan-Ethernal Stefan-Ethernal self-assigned this Feb 12, 2025
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review February 13, 2025 08:36
@Stefan-Ethernal Stefan-Ethernal added this to the AggKit - v0.1.0 milestone Feb 13, 2025
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/token-mappings-endpoint branch from 41a8aab to 395c17f Compare February 13, 2025 10:16
@Stefan-Ethernal Stefan-Ethernal removed this from the AggKit - v0.1.0 milestone Feb 13, 2025
@Stefan-Ethernal Stefan-Ethernal linked an issue Feb 15, 2025 that may be closed by this pull request
Provide bridge_getTokenMappings endpoint #190
Closed
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/token-mappings-endpoint branch from 0c3ef52 to e38bde9 Compare February 18, 2025 09:26
@Stefan-Ethernal Stefan-Ethernal changed the base branch from develop to feat/new-bridge-service February 18, 2025 11:06
temaniarpit27
temaniarpit27 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@temaniarpit27 temaniarpit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/token-mappings-endpoint branch from db932df to cb31b2e Compare February 18, 2025 14:30
@Stefan-Ethernal
chore: format openrpc file
98ea178
@Stefan-Ethernal
feat: index NewWrappedToken event in the bridge syncer
e6a8c84
@Stefan-Ethernal
refactor: replace hardcoded table names with constants in bridge sync…
71b1f13 
… processor
@Stefan-Ethernal
refactor: use common utility for converting bytes to uint32 in global…
1065f47 
… index decoding
@Stefan-Ethernal
fix: typos
67a80a8
@Stefan-Ethernal
fix: attempt to fix the e2e tests
5b352b8
@Stefan-Ethernal
chore: add missing new lines in the migration files
a7fca0e
@Stefan-Ethernal
fix: add input validation and padding for BytesToUint32 and BytesToUi…
1304d4e 
…nt64 functions
@Stefan-Ethernal
feat: implement token mapping fetch logic
61534b6
@Stefan-Ethernal
fix: suppress linter duplication warning
4cdffb3
@Stefan-Ethernal
feat: expose bridge_getTokenMappings RPC endpoint
53140f5
@Stefan-Ethernal
feat: introduce transaction hash and block timestamp into token mapping
7330b4b
@Stefan-Ethernal
feat: document bridge_getTokenMapping in the openrpc format
4eb3e59
@Stefan-Ethernal
feat: implement GetTokenMappings unit tests
ea3098a
@Stefan-Ethernal
test: common package unit tests
1b2987e
@Stefan-Ethernal
test: bridge sync get tokens mapping UTs
6c2d40a
@Stefan-Ethernal
refactor: reduce cognitive complexity by extracting the private funct…
50f2fae 
…ions
@Stefan-Ethernal
test: change error check in the processor.GetTokenMappings test
e0688d9
@Stefan-Ethernal
fix: TestGetTokenMappings UT
894b4c0
@Stefan-Ethernal
test: inconsistent state test case for get token mappings
c8d31b8
@Stefan-Ethernal
test: bridgesync downloader buildAppender UT
f91b525
@Stefan-Ethernal
test: BytesToUint64 add panics test case
c9ac270
@Stefan-Ethernal
test: add claimEventPreEtrog test case
8775df1
@Stefan-Ethernal
chore: format
61198be
@Stefan-Ethernal
chore: bump cdk-rpc dependency
8c7d81d
@Stefan-Ethernal
feat: add logs and cleanups
5a9792c
@Stefan-Ethernal
fix: remove validium and rollup for DATA_AVAILABILITY_MODE parameter
895ea67
@Stefan-Ethernal
feat: update GetTokenMappings to use uint32 parameters and move pagin…
9c0fce2 
…ation validation
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/token-mappings-endpoint branch from cb31b2e to 9c0fce2 Compare February 19, 2025 14:17
@Stefan-Ethernal Stefan-Ethernal merged commit ee07ffc into feat/new-bridge-service Feb 19, 2025
6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the feat/token-mappings-endpoint branch February 19, 2025 14:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
79.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@temaniarpit27 temaniarpit27 temaniarpit27 approved these changes

@rachit77 rachit77 rachit77 approved these changes

@vcastellm vcastellm Awaiting requested review from vcastellm

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide bridge_getTokenMappings endpoint
3 participants
@Stefan-Ethernal @temaniarpit27 @rachit77