Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for external signer #202

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Feb 10, 2025

Description

How to adopt new method of signing:

  • Change the struct type types.KeystoreFileConfig for configuring the key to signer.SignerConfig
  • Define the field Method to: local or web3signer. If not set is local
  • The config file are 100% compatible with previous types.KeystoreFileConfig, so no user friction
  • An old configuration like this is mapped to local:
{Path = "/app/keystore/claimsopnsor.keystore", Password = "testonly"}
  • New web3signer: This use a server web3signer to store the keys an invoke the sign process using a API. To configure it you need to set:
{Method = "web3signer", URL = "http://localhost:8545", Address = "0x1234567890abcdef"}
  • Method (mandatory): sign methor
  • URL (mandatory): web3singer server
  • Address (optional): Public key to use to sign, if this field is empty it try to guess the key to use, so if the server only have 1 key that this one is used.

Fixes #194

@joanestebanr joanestebanr force-pushed the feature/external_signer_194 branch from 648eef0 to a32a414 Compare February 10, 2025 16:02
@joanestebanr joanestebanr changed the title feat: wip Feature: add support for external signer Feb 10, 2025
@joanestebanr joanestebanr changed the title Feature: add support for external signer feat: add support for external signer Feb 17, 2025
@joanestebanr joanestebanr marked this pull request as ready for review February 21, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant