-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for external signer #202
Open
joanestebanr
wants to merge
16
commits into
develop
Choose a base branch
from
feature/external_signer_194
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf64a3a
to
e61d549
Compare
648eef0
to
a32a414
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to adopt new method of signing:
types.KeystoreFileConfig
for configuring the key tosigner.SignerConfig
Method
to:local
orweb3signer
. If not set islocal
types.KeystoreFileConfig
, so no user frictionlocal
:web3signer
: This use a server web3signer to store the keys an invoke the sign process using a API. To configure it you need to set:Method
(mandatory): sign methorURL
(mandatory): web3singer serverAddress
(optional): Public key to use to sign, if this field is empty it try to guess the key to use, so if the server only have 1 key that this one is used.Fixes #194