Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pessimistic mode #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

invocamanman
Copy link
Contributor

@invocamanman invocamanman commented Mar 18, 2025

Description

  • Do not check "l1head" in optimistic mode (ECDSA).
  • Add extra fields to the signature to accommodate future upgrades and enhance robustness.
  • Update the claim indexes for claim Bridge exits

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@invocamanman invocamanman requested a review from a team as a code owner March 18, 2025 17:16
@invocamanman invocamanman force-pushed the feat-udpate-optimistic-mode branch from 6d80892 to c77c0dc Compare March 18, 2025 17:37
@invocamanman invocamanman requested a review from hadjiszs March 18, 2025 17:37
@invocamanman invocamanman changed the title op mode feat: update pessimistic mode Mar 19, 2025
@invocamanman invocamanman force-pushed the feat-udpate-optimistic-mode branch from c77c0dc to 7f5ba7c Compare March 19, 2025 11:56
Copy link

@Ekleog-Polygon Ekleog-Polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Though I'm not familiar with the aggchain proof domain just yet; I'll let @hadjiszs approve formally once his comments will be handled :)

@invocamanman invocamanman force-pushed the feat-udpate-optimistic-mode branch from 9ee45d7 to 52011b6 Compare March 21, 2025 19:18
@invocamanman invocamanman force-pushed the feat-udpate-optimistic-mode branch from 52011b6 to 0730184 Compare March 21, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants