Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where opening the side pane causes messages to become too tall #531

Conversation

cousincrusher
Copy link
Contributor

repro:

  • wraparound OFF
  • open chat with long messages (multi bot might help? idk)
  • open sidepane, then close it
  • messages are way taller than needed because the current logic cannot detect when the message box's size goes down, only when it goes up!!!

fix used:

  • instead of observing changes in the entire message box's size, including the element we add a min-height to itself, we observe changes to the text field only
  • we have to add + 1em or it's not accurate, check that it works well on other PCs than mine

repro:
- wraparound OFF
- open chat with long messages (multi bot might help? idk)
- open sidepane, then close it
- messages are way taller than needed because the current logic cannot
  detect when the message box's size goes down, only when it goes up!!!

fix used:
- instead of observing changes in the entire message box's size,
  including the element we add a min-height to itself, we observe
  changes to the text field only
- we have to add + 1em or it's not accurate, check that it works well on
  other PCs than mine
@sceuick
Copy link
Member

sceuick commented Jul 30, 2023

I included this commit in another PR.

@sceuick sceuick closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants