filter-sidebar: Enhanced documentation and guidance around mobile usage. #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded on existing content.
🦋 Changeset detectedLatest commit: 21bdc21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
stowball
reviewed
Dec 19, 2024
| @@ -8,7 +8,7 @@ relatedPatterns: ['search-filters'] | |||
|
|
|||
| Filter sidebar is used in catalogue or search results pages to contain filtering options for a list of Cards. | |||
|
|
|||
| The Filter sidebar collapses on mobile devices, and displays a number of active filter options in the header. | |||
| The Filter sidebar collapses on mobile devices into an accordion, where the number of active filter options is displayed prominently in the header. Individual filter tags are displayed outside of the accordion, providing users with a clear, interactive way to view and remove specific filters as needed. | |||
There was a problem hiding this comment.
Filter tags aren't part of this component, so I think this should be more "if you add filter tags" or it should be added to the patterns/search-filters documentation
Edited to reflect that filter tags are not part of the component, so changed language to "can"
Added tags as related component
filter-sidebar: Enhanced documentation and guidance around mobile usage.
danger17
changed the title
|
stowball
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded on existing content.
View preview
Checklist
Preflight
accordion: Updated paddingordocs: Updated header linksyarn changeset. Learn more about change management.Testing
yarn testto ensure tests are passing. If required, runyarn test -uto update any generated snapshots.Documentation