Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list: Fix docs examples #1941

Merged
merged 2 commits into from
Feb 18, 2025
Merged

list: Fix docs examples #1941

merged 2 commits into from
Feb 18, 2025

Conversation

ChrisLaneAU
Copy link
Contributor

@ChrisLaneAU ChrisLaneAU commented Jan 31, 2025

The list examples were found to have incorrect and confusing examples.

View preview

Checklist

Preflight

  • Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
  • Describe the changes clearly in the PR description
  • Read and check your code before tagging someone for review
  • Create a changeset file by running yarn changeset. Learn more about change management.

Testing

  • Manually test component in various modern browsers at various sizes (use Browserstack)
  • Manually test component in various devices (phone, tablet, desktop)
  • Manually test component using a keyboard
  • Manually test component using a screen reader
  • Manually tested in dark mode
  • Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
  • Add any necessary unit tests (HTML validation, snapshots etc)
  • Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Documentation

  • Create or update documentation on the website
  • Create or update stories for Storybook
  • Create or update stories for Playroom snippets

@ChrisLaneAU ChrisLaneAU requested a review from stowball January 31, 2025 05:04
@ChrisLaneAU ChrisLaneAU self-assigned this Jan 31, 2025
Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: f260fb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ag.ds-next/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-18 04:43 UTC

Copy link

sonarqubecloud bot commented Feb 3, 2025

@stowball stowball marked this pull request as ready for review February 3, 2025 05:54
@stowball stowball changed the title Fix unordered list and ordered list items list: Fix docs examples Feb 3, 2025
@stowball stowball merged commit 8adc094 into develop Feb 18, 2025
8 checks passed
@stowball stowball deleted the readme-update branch February 18, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants